Conversation
|
|
||
| ### Simplify libp2p Setup Logic with Fx 🦄 | ||
|
|
||
| In [v0.24.0](https://github.com/libp2p/go-libp2p/releases/tag/v0.24.0) go-libp2p included a change to use [Fx](https://github.com/uber-go/fx), a Go dependency injection library. |
Contributor
There was a problem hiding this comment.
Not really, this is not an outwards-facing change.
It just massively simplified how we construct our transports, and it will enable us to properly start and stop libp2p services in the future (see libp2p/go-libp2p#1993).
Member
Author
|
@marten-seemann @MarcoPolo may I get your review, I'll publish this today |
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 18.5%, saving 134.78 KB.
44 images did not require optimisation. |
Co-authored-by: Danny Salman <[email protected]>
Co-authored-by: Max Inden <[email protected]>
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 16.4%, saving 81.83 KB.
45 images did not require optimisation. |
MarcoPolo
approved these changes
Feb 14, 2023
BigLep
added a commit
that referenced
this pull request
Feb 17, 2023
Followup on #33 since I missed the review there Areas of focus: 1. Making clear that this is the EngRes go-libp2p team. I know there isn't another team currently, but we would love it if there was. 2. Clarifying QUIC heading 3. Moving some things up that were should be considered features I believe.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.